On Wed, Oct 09, 2019 at 01:03:19AM +0900, Masahiro Yamada wrote: [...] > > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile > > index ef2f2336c469..2ee46301b22e 100644 > > --- a/scripts/kconfig/Makefile > > +++ b/scripts/kconfig/Makefile > > @@ -104,6 +104,10 @@ PHONY += xenconfig > > xenconfig: xen.config > > @: > > > > +PHONY += hvconfig > > +hvconfig: hv_guest.config > > + @: > > + > > > Does this need to be hooked up to kconfig Makefile? > It is not strictly necessary. Just thought it would be nice to follow existing examples. > In my understanding, this code provides > "make hvconfig" as a shorthand for "make hv_guest.config" > Yes that's correct. > Please do not do this. > > > See "xenconfig" as a bad example. > > "make xenconfig" is a shorthand of "make xen.config". > This exists to save just one character typing. > > > If I allow this, people would push more and more random pointless shorthands, > which are essentially unrelated to kconfig. > > > kvmconfig and xenconfig are just historical mistakes. > > > Please drop the changes to scripts/kconfig/Makefile. OK. > > Also, please do not use misleading "kconfig:" for the subject prefix. > You can use the subject prefix "hyper-v:" or something. > OK. Wei.
