On Thu, 5 Sep 2019 23:07:32 +0000, Haiyang Zhang wrote: > > On Fri, 30 Aug 2019 03:45:38 +0000, Haiyang Zhang wrote: > > > VF NIC may go down then come up during host servicing events. This > > > causes the VF NIC offloading feature settings to roll back to the > > > defaults. This patch can synchronize features from synthetic NIC to > > > the VF NIC during ndo_set_features (ethtool -K), and > > > netvsc_register_vf when VF comes back after host events. > > > > > > Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > > > Cc: Mark Bloch <markb@xxxxxxxxxxxx> > > > > If we want to make this change in behaviour we should change net_failover > > at the same time. > > After checking the net_failover, I found it's for virtio based SRIOV, and very > different from what we did for Hyper-V based SRIOV. > > We let the netvsc driver acts as both the synthetic (PV) driver and the transparent > bonding master for the VF NIC. But net_failover acts as a master device on top > of both virtio PV NIC, and VF NIC. And the net_failover doesn't implemented > operations, like ndo_set_features. > So the code change for our netvsc driver cannot be applied to net_failover driver. > > I will re-submit my two patches (fixing the extra tab in the 1st one as you pointed > out). Thanks! I think it stands to reason that two modules which implement the same functionality behave the same.
