> -----Original Message-----
> From: David Miller <davem@xxxxxxxxxxxxx>
> Sent: Tuesday, August 20, 2019 3:29 PM
> To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Cc: sashal@xxxxxxxxxx; saeedm@xxxxxxxxxxxx; leon@xxxxxxxxxx;
> eranbe@xxxxxxxxxxxx; lorenzo.pieralisi@xxxxxxx; bhelgaas@xxxxxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx; linux-hyperv@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; KY Srinivasan <kys@xxxxxxxxxxxxx>; Stephen
> Hemminger <sthemmin@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next,v2 2/6] PCI: hv: Add a Hyper-V PCI interface
> driver for software backchannel interface
>
> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Date: Mon, 19 Aug 2019 19:30:47 +0000
>
> > +static void __exit exit_hv_pci_intf(void) {
> > + pr_info("unloaded\n");
> > +}
> > +
> > +static int __init init_hv_pci_intf(void) {
> > + pr_info("loaded\n");
> > +
>
> Clogging up the logs with useless messages like this is inappropriate.
> Please remove these pr_info() calls.
>
> Also, all of these symbols should probably be GPL exported.
I will update the patch -- remove the pr_info, and use EXPORT_SYMBOL_GPL()
for the symbols.
Thanks,
- Haiyang
