On Mon, Aug 19, 2019 at 10:44:48PM -0400, Branden Bonaby wrote: > Expose the test parameters as part of the debugfs channel attributes. > We will control the testing state via these attributes. > > Signed-off-by: Branden Bonaby <brandonbonaby94@xxxxxxxxx> > --- > Changes in v2: > - Move test attributes to debugfs. > - Wrap test code under #ifdef statements. > - Add new documentation file under Documentation/ABI/testing. > - Make commit message reflect the change from from sysfs to debugfs. > > > + if (IS_ERR_OR_NULL(dev_root)) { > + pr_debug("debugfs_hyperv: %s/%s/ not created\n", > + TESTING, device); > + return PTR_ERR(dev_root); > + } Whoops, that single IS_ERR_OR_NULL shouldn't be there, it should just be IS_ERR I'll change and resend the patch.