> -----Original Message----- > From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> > Sent: Friday, August 16, 2019 12:16 PM > To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Stephen Hemminger > <sthemmin@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > sashal@xxxxxxxxxx; davem@xxxxxxxxxxxxx; saeedm@xxxxxxxxxxxx; > leon@xxxxxxxxxx; eranbe@xxxxxxxxxxxx; lorenzo.pieralisi@xxxxxxx; > bhelgaas@xxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux- > hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx > Subject: RE: [PATCH net-next, 2/6] PCI: hv: Add a Hyper-V PCI mini driver for > software backchannel interface > > Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> writes: > > > > > The pci_hyperv can only be loaded on VMs on Hyper-V and Azure. Other > > drivers like MLX5e will have symbolic dependency of pci_hyperv if they > > use functions exported by pci_hyperv. This dependency will cause other > > drivers fail to load on other platforms, like VMs on KVM. So we > > created this mini driver, which can be loaded on any platforms to > > provide the symbolic dependency. > > (/me wondering is there a nicer way around this, by using __weak or > something like that...) > > In case this stub is the best solution I'd suggest to rename it to something like > PCI_HYPERV_INTERFACE to make it clear it is not a separate driver (_MINI > makes me think so). Thanks! I will consider those options.
