> -----Original Message----- > From: Wenwen Wang <wenwen@xxxxxxxxxx> > Sent: Wednesday, August 14, 2019 4:16 PM > To: Wenwen Wang <wenwen@xxxxxxxxxx> > Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang > <haiyangz@xxxxxxxxxxxxx>; Stephen Hemminger > <sthemmin@xxxxxxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>; David S. > Miller <davem@xxxxxxxxxxxxx>; open list:Hyper-V CORE AND DRIVERS > <linux-hyperv@xxxxxxxxxxxxxxx>; open list:NETWORKING DRIVERS > <netdev@xxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx> > Subject: [PATCH] hv_netvsc: Fix a memory leak bug > > In rndis_filter_device_add(), 'rndis_device' is allocated through kzalloc() > by invoking get_rndis_device(). In the following execution, if an error > occurs, the execution will go to the 'err_dev_remv' label. However, the > allocated 'rndis_device' is not deallocated, leading to a memory leak bug. > > Signed-off-by: Wenwen Wang <wenwen@xxxxxxxxxx> > --- > drivers/net/hyperv/rndis_filter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/hyperv/rndis_filter.c > b/drivers/net/hyperv/rndis_filter.c > index 317dbe9..ed35085 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -1420,6 +1420,7 @@ struct netvsc_device > *rndis_filter_device_add(struct hv_device *dev, > > err_dev_remv: > rndis_filter_device_remove(dev, net_device); > + kfree(rndis_device); The kfree() is not necessary here. Because it is already freed by -- rndis_filter_device_remove() --> netvsc_device_remove() --> free_netvsc_device_rcu() --> free_netvsc_device() --> kfree(nvdev->extension); //This frees rndis_device. Thanks, - Haiyang
