> -----Original Message----- > From: linux-hyperv-owner@xxxxxxxxxxxxxxx <linux-hyperv-owner@xxxxxxxxxxxxxxx> On Behalf Of Dexuan Cui > Sent: Friday, June 14, 2019 10:01 PM > To: netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; Michael Kelley <mikelley@xxxxxxxxxxxxx> > Cc: linux-hyperv@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; KY Srinivasan <kys@xxxxxxxxxxxxx>; Stephen Hemminger > <sthemmin@xxxxxxxxxxxxx>; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>; Sasha Levin <Alexander.Levin@xxxxxxxxxxxxx>; > olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; vkuznets <vkuznets@xxxxxxxxxx>; marcelo.cerri@xxxxxxxxxxxxx; > Dexuan Cui <decui@xxxxxxxxxxxxx> > Subject: [PATCH net] hv_sock: Suppress bogus "may be used uninitialized" warnings > > gcc 8.2.0 may report these bogus warnings under some condition: > > warning: ‘vnew’ may be used uninitialized in this function > warning: ‘hvs_new’ may be used uninitialized in this function > > Actually, the 2 pointers are only initialized and used if the variable > "conn_from_host" is true. The code is not buggy here. > > Signed-off-by: Dexuan Cui <decui@xxxxxxxxxxxxx> > --- > net/vmw_vsock/hyperv_transport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c > index 8d1ea9eda8a2..cd3f47f54fa7 100644 > --- a/net/vmw_vsock/hyperv_transport.c > +++ b/net/vmw_vsock/hyperv_transport.c > @@ -329,8 +329,8 @@ static void hvs_open_connection(struct vmbus_channel *chan) > > struct sockaddr_vm addr; > struct sock *sk, *new = NULL; > - struct vsock_sock *vnew; > - struct hvsock *hvs, *hvs_new; > + struct vsock_sock *vnew = NULL; > + struct hvsock *hvs, *hvs_new = NULL; > int ret; > These are all already fixed under https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=ac383f58f3c98de37fa67452acc5bd677396e9f3 Its just that that commit hasn't merged with the 'net' branch yet. > if_type = &chan->offermsg.offer.if_type; > -- > 2.19.1
