Hi Sung-Chi, On 2025-03-13 12:47:41+0800, Sung-Chi Li wrote: > ChromeOS embedded controller (EC) supports closed-loop fan control. We > anticipate to have the fan related control from the kernel side, so this > series register the HWMON_F_TARGET attribute, and implement the read and > write function for setting/reading the target fan RPM from the EC side. In general the idea is fine. I'll post some comments for the patches. The series should be squashed into a single patch. All the new code is closely related to each other. > Signed-off-by: Sung-Chi Li <lschyi@xxxxxxxxxxxx> > --- > Sung-Chi Li (3): > hwmon: (cros_ec) Add setting target fan RPM function > hwmon: (cros_ec) Add reading target fan RPM function > hwmon: (cros_ec) Register fan target attribute > > drivers/hwmon/cros_ec_hwmon.c | 69 +++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 64 insertions(+), 5 deletions(-) > --- > base-commit: 9fbcd7b32bf7c0a5bda0f22c25df29d00a872017 > change-id: 20250313-extend_ec_hwmon_fan-a5f59aab2cb3 > > Best regards, > -- > Sung-Chi Li <lschyi@xxxxxxxxxxxx>
