On 3/9/25 15:04, Gerhard Engleder wrote:
FWIW, all those COMPILE_TEST dependencies are pointless:
drivers/i2c/busses/Kconfig: depends on KEBA_CP500 || COMPILE_TEST
drivers/misc/keba/Kconfig: depends on KEBA_CP500 || COMPILE_TEST
drivers/spi/Kconfig: depends on KEBA_CP500 || COMPILE_TEST
Ok, I won't add them anymore.
On top of that, both SPI_KSPI2 and I2C_KEBA select AUXILIARY_BUS
which is equally pointless because KEBA_CP500 already does that.
I2C_KEBA depends on HAS_IOMEM but I2C itself already depends on it.
I'm sorry, I didn't know that Kconfig must be strictly minimized.
It doesn't, it just has no value if it isn't, and it is to some degree
misleading. Following your logic, the unnecessary COMPILE_TEST don't
matter either. Of course, if there is some problem with those COMPILE_TEST
dependencies in the future, and someone will drop them, there will be
a bit of a surprise when the drivers are built anyway. _That_ is why one
would normally avoid redundant dependencies.
It is also ... odd ... that KEBA_CP500 depends on I2C. So it isn't
possible to enable any of its sub-devices without also enabling I2C.
It is not immediately obvious why this would be necessary.
The cp500 driver uses functions of the I2C subsystem to find a defined
EEPROM.
Ok.
Thanks,
Guenter
