Re: [PATCH] [PATCH v3] hwmon: (pmbus/isl68137) Add support for RAA229621

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 03, 2025 at 04:35:37PM +0800, Chiang Brian wrote:
> From: Chiang Brian <chiang.brian@xxxxxxxxxxxx>
> 
> From: Chiang Brian<chiang.brian@xxxxxxxxxxxx>
> 

?

> The RAA229621 is a digital dual output multiphase
> (X+Y ≤ 8) PWM controller designed to be compliant
> with AMD SVI3 specifications, targeting
> VDDCR_CPU and VDDCR_SOC rails.
> Add support for it to the isl68137 driver.
> 
> Signed-off-by: Chiang Brian <chiang.brian@xxxxxxxxxxxx>

Again no change log. Please consider this the last warning: I will not
apply any of your patches unless you provide change logs.

checkpatch says

WARNING: DT compatible string "renesas,raa229621" appears un-documented -- check ./Documentation/devicetree/bindings/
#139: FILE: drivers/hwmon/pmbus/isl68137.c:517:
+	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },

The new compatible needs to be documented.

Guenter




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux