On Tue, Feb 11, 2025 at 02:22:31PM +0800, ChiangBrian 江泳緻 TAO wrote:
> From: Brian Chiang<chiang.brian@xxxxxxxxxxxx>
>
> The TPS53685 is a fully AMD SVI3 compliant step down
> controller with trans-inductor voltage regulator
> (TLVR) topology support, dual channels, built-in
> non-volatile memory (NVM), PMBus™ interface, and
> full compatible with TI NexFET™ smart power
> stages.
> Add support for it to the tps53679 driver.
>
> Signed-off-by: Chiang Brian <chiang.brian@xxxxxxxxxxxx>
The persisient lack of change logs does not help moving this patch forward.
Worse, it is corrupted and does not apply.
> diff --git a/drivers/hwmon/pmbus/tps53679.c b/drivers/hwmon/pmbus/tps53679.c
> index 63524dff5e75..7b412f3fe86a 100644
> --- a/drivers/hwmon/pmbus/tps53679.c
> +++ b/drivers/hwmon/pmbus/tps53679.c
...
> - if (ret != 1 || buf[0] != id) {
> - dev_err(&client->dev, "Unexpected device ID 0x%x\n", buf[0]);
> + if (ret != strlen(id) || strncmp(id, buf, ret)) {
> + dev_err(&client->dev, "Unexpected device ID: %*ph\n", buf);
%*ph requires the buffer length as argument. Testing this out by applying
just this line, the code does not even compile. That strongly suggests
that the change was not compile tested, much less tested on real
hardware. To move this forward, I'll want t see a boot log.
Guenter
