Re: [PATCH] hwmon: (pmbus) Initialise page count in pmbus_identify()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 27, 2025 at 10:24:55PM +0000, Titus Rwantare wrote:
> The `pmbus_identify()` function fails to correctly determine the number
> of supported pages on PMBus devices. This occurs because `info->pages`
> is implicitly zero-initialised, and `pmbus_set_page()` does not perform
> writes to the page register if `info->pages` is not yet initialised.
> Without this patch, `info->pages` is always set to the maximum after
> scanning.
> 
> This patch initialises `info->pages` to `PMBUS_PAGES` before the probing
> loop, enabling `pmbus_set_page()` writes to make it out onto the bus
> correctly identifying the number of pages. `PMBUS_PAGES` seemed like a
> reasonable non-zero number because that's the current result of the
> identification process.
> 
> Testing was done with a PMBus device in QEMU.
> 
> Signed-off-by: Titus Rwantare <titusr@xxxxxxxxxx>

Applied.

Thanks,
Guenter




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux