On 2/11/2025 12:58 PM, Dave Hansen wrote: > On 2/11/25 11:43, Sohil Mehta wrote: >> + /* >> + * Return without adjustment if the Family isn't 6. >> + * The rest of the function assumes Family 6. >> + */ >> + if (c->x86 != 6) >> + return tjmax; > > Shouldn't we be converting this over to the vfm matches? > For drivers/, I mainly focused on fixes instead of cleanups. Converting drivers over to VFM checks is significant work. There are a lot of such comparisons and switch cases (probably more than 50) across drivers/cpufreq/ and drivers/hwmon/. Some of the functions might need significant refactoring and rewrites. I think someone with expertise in that particular driver should probably do it. I did start with it initially but it is beyond my bandwidth at the moment. > This is kinda icky: > >> + return family > 15 || >> + (family == 6 && >> + model > 0xe && >> + model != 0x1c && >> + model != 0x26 && >> + model != 0x27 && >> + model != 0x35 && >> + model != 0x36); >> } > > I'm not sure how this escaped so far. Probably because it's not in arch/x86. >
