We should really rename intel_workarounds() to make it more clear that it's 32-bit only. But I digress... On 2/11/25 11:43, Sohil Mehta wrote: > The alignment preference for 32-bit movsl based bulk memory move has > been 8-byte for a long time. However this preference is only set for > Family 6 and 15 processors. > > Extend the preference to upcoming Family numbers 18 and 19 to maintain > legacy behavior. Also, use a VFM based check instead of switching based > on Family numbers. Refresh the comment to reflect the new check. "Legacy behavior" is not important here. If anyone is running 32-bit kernel binaries on their brand new CPUs they (as far as I know) have a few screws loose. They don't care about performance or security and we shouldn't care _for_ them. If the code yielded the "wrong" movsl_mask.mask for 18/19, it wouldn't matter one bit. The thing that _does_ matter is someone auditing to figure out whether the code comprehends families>15 or whether it would break in horrible ways. The new check is shorter and it's more obvious that it will work forever. Acked-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
