Hi Guenter, Thanks for reviewing the patch and for your feedback. I will document device tree attributes in a separate patch as suggested. Best regards, Florin -----Original Message----- From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck Sent: Monday, February 10, 2025 6:15 PM To: Florin Leotescu (OSS) <florin.leotescu@xxxxxxxxxxx>; Jean Delvare <jdelvare@xxxxxxxx>; linux-hwmon@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Viorel Suman <viorel.suman@xxxxxxx> Cc: Florin Leotescu <florin.leotescu@xxxxxxx> Subject: [EXT] Re: [PATCH 2/2] hwmon: emc2305: Add device tree support for polarity and pwm output Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button On 2/9/25 23:31, florin.leotescu@xxxxxxxxxxx wrote: > From: Florin Leotescu <florin.leotescu@xxxxxxx> > > The patch enhances emc2305 driver by adding support for configuring > pwm output and polarity via Device Tree properties. > > Signed-off-by: Florin Leotescu <florin.leotescu@xxxxxxx> You can not just add support for devictree attributes to a driver without documenting it in a devicetree .yaml file and getting it approved by devicetree maintainers. Guenter
