On Tue, Jan 21, 2025 at 12:03:37AM +0530, Atharva Tiwari wrote: > This patch adds support for fan control on T2 Macs in the applesmc driver. > It introduces functions to handle floating-point fan speed values > (which are required by t2 chips). > The fan speed reading and writing are updated to > support both integer and floating-point values. > The fan manual control is also updated to handle T2 Mac-specific keys. > > Guenter Roeck asked "Does this limit still apply?" > so yes the limit still applies. > I just learned that this series originates from [1], that it should not be submitted on its own, and, worse, that it does not add T2 support without other patches which have not been submitted. As such, NACK for this patch. Please discuss with the t2 project if and when the series should be submitted into the upstream kernel. Guenter