On 1/26/25 23:03, Wolfram Sang wrote:
Hi Guenter,
Your patch is definitely one solution, but give me a day to think more
about it...
Sure.
So, the results of my thinking further and looking at some other debugfs
handling resulted in: I think your patch is fine :)
In this context, it would be great if client->debugfs was cleared if creating
the debugfs directory failed. While debugfs functions check if the dentry
pointer is valid, that is not the case for other kernel functions. Knowing
that the pointer is either NULL or valid would simplify drivers (such as the
PMBus code) which need to make that check.
Sure, we can do that. Can you add this to your patch and send it to the
lists? If possible I would like to apply it this merge-window.
Sure, I'll do that.
Thanks,
Guenter
