On 21.01.2025 17:10, Geert Uytterhoeven wrote:
> Hi Heiner,
>
> CC hwmon
>
> On Sat, 11 Jan 2025, Heiner Kallweit wrote:
>> This adds hwmon support for the temperature sensor on RTL822x.
>> It's available on the standalone versions of the PHY's, and on
>> the integrated PHY's in RTL8125B/RTL8125D/RTL8126.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
>
> Thanks for your patch, which is now commit 33700ca45b7d2e16
> ("net: phy: realtek: add hwmon support for temp sensor on
> RTL822x") in net-next.
>
>> --- a/drivers/net/phy/realtek/Kconfig
>> +++ b/drivers/net/phy/realtek/Kconfig
>> @@ -3,3 +3,9 @@ config REALTEK_PHY
>> tristate "Realtek PHYs"
>> help
>> Currently supports RTL821x/RTL822x and fast ethernet PHYs
>> +
>> +config REALTEK_PHY_HWMON
>> + def_bool REALTEK_PHY && HWMON
>> + depends on !(REALTEK_PHY=y && HWMON=m)
>> + help
>> + Optional hwmon support for the temperature sensor
>
> So this is optional, but as the symbol is invisible, it cannot be
> disabled by the user. Is that intentional?
>
Well, it isn't intentional in either direction.
Thanks for the hint, I should make it user-visible.
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>
