Hi Wenliang, kernel test robot noticed the following build warnings: [auto build test WARNING on groeck-staging/hwmon-next] [also build test WARNING on linus/master v6.13-rc7 next-20250113] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Wenliang-Yan/dt-bindings-Add-SQ52206-to-ina2xx-devicetree-bindings/20250113-115457 base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next patch link: https://lore.kernel.org/r/20250113035023.365697-3-wenliang202407%40163.com patch subject: [PATCH v2 2/2] hwmon:(ina238)Add support for SQ52206 config: csky-randconfig-002-20250114 (https://download.01.org/0day-ci/archive/20250114/202501140230.5s2Uytod-lkp@xxxxxxxxx/config) compiler: csky-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250114/202501140230.5s2Uytod-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202501140230.5s2Uytod-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): In file included from include/linux/err.h:5, from drivers/hwmon/ina238.c:9: drivers/hwmon/ina238.c: In function 'ina238_probe': >> include/linux/compiler.h:55:26: warning: suggest explicit braces to avoid ambiguous 'else' [-Wdangling-else] 55 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^ drivers/hwmon/ina238.c:699:9: note: in expansion of macro 'if' 699 | if (chip == sq52206) | ^~ drivers/hwmon/ina238.c: In function 'ina238_is_visible': >> drivers/hwmon/ina238.c:581:17: warning: this statement may fall through [-Wimplicit-fallthrough=] 581 | switch (attr) { | ^~~~~~ drivers/hwmon/ina238.c:594:9: note: here 594 | case hwmon_temp: | ^~~~ vim +581 drivers/hwmon/ina238.c eacb52f010a807 Nathan Rossi 2021-11-02 552 eacb52f010a807 Nathan Rossi 2021-11-02 553 static umode_t ina238_is_visible(const void *drvdata, eacb52f010a807 Nathan Rossi 2021-11-02 554 enum hwmon_sensor_types type, eacb52f010a807 Nathan Rossi 2021-11-02 555 u32 attr, int channel) eacb52f010a807 Nathan Rossi 2021-11-02 556 { f08436905922ae Wenliang Yan 2025-01-13 557 const struct ina238_data *data = drvdata; f08436905922ae Wenliang Yan 2025-01-13 558 bool has_power_highest = data->config->has_power_highest; f08436905922ae Wenliang Yan 2025-01-13 559 eacb52f010a807 Nathan Rossi 2021-11-02 560 switch (type) { eacb52f010a807 Nathan Rossi 2021-11-02 561 case hwmon_in: eacb52f010a807 Nathan Rossi 2021-11-02 562 switch (attr) { eacb52f010a807 Nathan Rossi 2021-11-02 563 case hwmon_in_input: eacb52f010a807 Nathan Rossi 2021-11-02 564 case hwmon_in_max_alarm: eacb52f010a807 Nathan Rossi 2021-11-02 565 case hwmon_in_min_alarm: eacb52f010a807 Nathan Rossi 2021-11-02 566 return 0444; eacb52f010a807 Nathan Rossi 2021-11-02 567 case hwmon_in_max: eacb52f010a807 Nathan Rossi 2021-11-02 568 case hwmon_in_min: eacb52f010a807 Nathan Rossi 2021-11-02 569 return 0644; eacb52f010a807 Nathan Rossi 2021-11-02 570 default: eacb52f010a807 Nathan Rossi 2021-11-02 571 return 0; eacb52f010a807 Nathan Rossi 2021-11-02 572 } eacb52f010a807 Nathan Rossi 2021-11-02 573 case hwmon_curr: eacb52f010a807 Nathan Rossi 2021-11-02 574 switch (attr) { eacb52f010a807 Nathan Rossi 2021-11-02 575 case hwmon_curr_input: eacb52f010a807 Nathan Rossi 2021-11-02 576 return 0444; eacb52f010a807 Nathan Rossi 2021-11-02 577 default: eacb52f010a807 Nathan Rossi 2021-11-02 578 return 0; eacb52f010a807 Nathan Rossi 2021-11-02 579 } eacb52f010a807 Nathan Rossi 2021-11-02 580 case hwmon_power: eacb52f010a807 Nathan Rossi 2021-11-02 @581 switch (attr) { eacb52f010a807 Nathan Rossi 2021-11-02 582 case hwmon_power_input: eacb52f010a807 Nathan Rossi 2021-11-02 583 case hwmon_power_max_alarm: eacb52f010a807 Nathan Rossi 2021-11-02 584 return 0444; eacb52f010a807 Nathan Rossi 2021-11-02 585 case hwmon_power_max: eacb52f010a807 Nathan Rossi 2021-11-02 586 return 0644; f08436905922ae Wenliang Yan 2025-01-13 587 case hwmon_power_input_highest: f08436905922ae Wenliang Yan 2025-01-13 588 if (has_power_highest) f08436905922ae Wenliang Yan 2025-01-13 589 return 0444; f08436905922ae Wenliang Yan 2025-01-13 590 break; eacb52f010a807 Nathan Rossi 2021-11-02 591 default: eacb52f010a807 Nathan Rossi 2021-11-02 592 return 0; eacb52f010a807 Nathan Rossi 2021-11-02 593 } eacb52f010a807 Nathan Rossi 2021-11-02 594 case hwmon_temp: eacb52f010a807 Nathan Rossi 2021-11-02 595 switch (attr) { eacb52f010a807 Nathan Rossi 2021-11-02 596 case hwmon_temp_input: eacb52f010a807 Nathan Rossi 2021-11-02 597 case hwmon_temp_max_alarm: eacb52f010a807 Nathan Rossi 2021-11-02 598 return 0444; eacb52f010a807 Nathan Rossi 2021-11-02 599 case hwmon_temp_max: eacb52f010a807 Nathan Rossi 2021-11-02 600 return 0644; eacb52f010a807 Nathan Rossi 2021-11-02 601 default: eacb52f010a807 Nathan Rossi 2021-11-02 602 return 0; eacb52f010a807 Nathan Rossi 2021-11-02 603 } eacb52f010a807 Nathan Rossi 2021-11-02 604 default: eacb52f010a807 Nathan Rossi 2021-11-02 605 return 0; eacb52f010a807 Nathan Rossi 2021-11-02 606 } eacb52f010a807 Nathan Rossi 2021-11-02 607 } eacb52f010a807 Nathan Rossi 2021-11-02 608 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
