On 1/10/25 13:10, Andrew Lunn wrote:
- over-temp alarm remains set, even if temperature drops below threshold+int rtl822x_hwmon_init(struct phy_device *phydev) +{ + struct device *hwdev, *dev = &phydev->mdio.dev; + const char *name; + + /* Ensure over-temp alarm is reset. */ + phy_clear_bits_mmd(phydev, MDIO_MMD_VEND2, RTL822X_VND2_TSALRM, 3);So it is possible to clear the alarm. I know you wanted to experiment with this some more.... If the alarm is still set, does that prevent the PHY renegotiating the higher link speed? If you clear the alarm, does that allow it to renegotiate the higher link speed? Or is a down/up still required? Does an down/up clear the alarm if the temperature is below the threshold? Also, does HWMON support clearing alarms? Writing a 0 to the file? Or are they supported to self clear on read?
Alarm attributes are supposed to self clear on read unless the condition persists.
I'm wondering if we are heading towards ABI issues? You have defined: - over-temp alarm remains set, even if temperature drops below threshold so that kind of eliminates the possibility of implementing self clearing any time in the future. Explicit clearing via a write is probably O.K, because the user needs to take an explicit action. Are there other ABI issues i have not thought about.
Alarm attributes are supposed to be read-only. Guenter
