On 1/1/25 06:15, John wrote:
The attached is my attempt to add support for a new MSI motherboard with a NCT6687D on board. I do not know why one of the sensors it reads gets reported at -40.0 however. Calling sensors multiple times shows that -40.0 value seems to bounce around from "Thermistor 0" and "Chipset B."
Feedback is appreciated.
Documentation/process/submitting-patches.rst
describes the canonical patch format. It also includes a chapter
"No MIME, no links, no compression, no attachments. Just plain text"
explaining why patches need to be submitted in plain text. This reply
is a perfect example: It does not include the patch itself, making
it all but impossible to provide comments on to actual code.
Please resend. The patch itself is almost ok, except I'd suggest to replace
"The value" with "The new customer ID" or similar in the patch description.
Also, please define the customer ID as "0x20d" (no leading 0) to be in line
with the other MSI customer IDs.
For reference, I attached a sample output of sensors for the new chip with this patch applied:
This and the output would be useful after "---" in the actual
patch. It provides the context while avoiding sending the patch as
attachment.
Thanks,
Guenter
nct6687-isa-0a20
Adapter: ISA adapter
VIN0: 1.01 V (min = +0.00 V, max = +0.00 V)
VIN1: 1.01 V (min = +0.00 V, max = +0.00 V)
VIN2: 1.30 V (min = +0.00 V, max = +0.00 V)
VIN3: 672.00 mV (min = +0.00 V, max = +0.00 V)
VIN4: 1.01 V (min = +0.00 V, max = +0.00 V)
VIN5: 2.03 V (min = +0.00 V, max = +0.00 V)
VIN6: 464.00 mV (min = +0.00 V, max = +0.00 V)
VIN7: 1.52 V (min = +0.00 V, max = +0.00 V)
VCC: 3.28 V (min = +0.00 V, max = +0.00 V)
VSB: 3.33 V (min = +0.00 V, max = +0.00 V)
AVSB: 3.33 V (min = +0.00 V, max = +0.00 V)
VTT: 2.03 V (min = +0.00 V, max = +0.00 V)
VBAT: 3.18 V (min = +0.00 V, max = +0.00 V)
VREF: 1.79 V (min = +0.00 V, max = +0.00 V)
fan1: 747 RPM (min = 0 RPM)
fan2: 745 RPM (min = 0 RPM)
fan3: 0 RPM (min = 0 RPM)
fan4: 0 RPM (min = 0 RPM)
fan12: 0 RPM (min = 0 RPM)
fan13: 0 RPM (min = 0 RPM)
fan14: 0 RPM (min = 0 RPM)
fan15: 0 RPM (min = 0 RPM)
fan16: 0 RPM (min = 0 RPM)
AMD TSI Addr 98h: +49.0°C (low = +0.0°C)
(high = +0.0°C, hyst = +0.0°C)
(crit = +0.0°C) sensor = AMD AMDSI
Diode 0 (curr): +56.0°C (low = +0.0°C)
(high = +0.0°C, hyst = +0.0°C)
(crit = +0.0°C) sensor = thermal diode
Thermistor 15: +52.0°C (low = +0.0°C)
(high = +124.0°C, hyst = +34.0°C)
(crit = +0.0°C) sensor = thermistor
SMBus 0: +56.0°C (low = +0.0°C)
(high = +0.0°C, hyst = +0.0°C)
(crit = +0.0°C)
SMBus 1: +56.0°C (low = +0.0°C)
(high = +0.0°C, hyst = +0.0°C)
(crit = +0.0°C)
Thermistor 0: -40.0°C (low = +0.0°C)
(high = +0.0°C, hyst = +0.0°C)
(crit = +0.0°C) sensor = thermistor
Thermistor 15: +52.0°C (low = +0.0°C)
(high = +124.0°C, hyst = +34.0°C)
(crit = +0.0°C) sensor = thermistor
intrusion0: ALARM
beep_enable: disabled
