On Thu, Dec 26, 2024 at 06:00:19PM +0100, tjakobi@xxxxxxxxxxxxxxxxxxxxx wrote: > From: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx> > > The driver is in full control of the enable mode, so we > don't need to read it from HW every single time. > That is not a reason for adding that much additional code. What is the problem that is being solved, and why is it worth that much additional code ? Plus, again, all those runtime feature checks in attribute handling code are completely wrong. Guenter