On Sat, Dec 14, 2024 at 09:58:32AM +0100, Wolfram Sang wrote:
> Make use of the new generic helper for calculating the parity.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/hwmon/spd5118.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c
> index 6cee48a3e5c3..07ab3a47b00c 100644
> --- a/drivers/hwmon/spd5118.c
> +++ b/drivers/hwmon/spd5118.c
> @@ -291,12 +291,6 @@ static umode_t spd5118_is_visible(const void *_data, enum hwmon_sensor_types typ
> }
> }
>
> -static inline bool spd5118_parity8(u8 w)
> -{
> - w ^= w >> 4;
> - return (0x6996 >> (w & 0xf)) & 1;
> -}
> -
> /*
> * Bank and vendor id are 8-bit fields with seven data bits and odd parity.
> * Vendor IDs 0 and 0x7f are invalid.
> @@ -304,7 +298,7 @@ static inline bool spd5118_parity8(u8 w)
> */
> static bool spd5118_vendor_valid(u8 bank, u8 id)
> {
> - if (!spd5118_parity8(bank) || !spd5118_parity8(id))
> + if (get_parity8(bank) == 0 || get_parity8(id) == 0)
> return false;
>
> id &= 0x7f;
> --
> 2.45.2
>
