[bug report] hwmon: (pmbus/tps25990) Add initial support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jerome Brunet,

Commit 6fbd1e5d9876 ("hwmon: (pmbus/tps25990) Add initial support")
from Dec 2, 2024 (linux-next), leads to the following Smatch static
checker warning:

	drivers/hwmon/pmbus/tps25990.c:134 tps25990_read_word_data()
	warn: ignoring unreachable code.

drivers/hwmon/pmbus/tps25990.c
    127         case PMBUS_VIRT_READ_IIN_AVG:
    128                 ret = pmbus_read_word_data(client, page, phase,
    129                                            TPS25990_READ_IIN_AVG);
    130                 break;
    131 
    132         case PMBUS_VIRT_READ_IIN_MAX:
    133                 return TPS25990_READ_IIN_PEAK;
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

--> 134                 ret = pmbus_read_word_data(client, page, phase,
    135                                            TPS25990_READ_IIN_PEAK);

Is this supposed to be stubbed out?

    136                 break;
    137 
    138         case PMBUS_VIRT_READ_TEMP_AVG:
    139                 ret = pmbus_read_word_data(client, page, phase,
    140                                            TPS25990_READ_TEMP_AVG);

regards,
dan carpenter




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux