Re: [PATCH] hwmon: (tmp108) Do not fail in I3C probe when I3C regmap is a module

[Guenter Roeck <linux@xxxxxxxxxxxx>]

Hi Jarkko,

On 11/21/24 04:18, Jarkko Nikula wrote:
> I3C device probe fails when CONFIG_REGMAP_I3C=m:
>
> 	p3t1085_i3c 0-23615290090: error -ENODEV: Failed to register i3c regmap
>
> Fix this by using the IS_ENABLED(CONFIG_REGMAP_I3C) macro in the code.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>

Thanks a lot for the report and the patch. Turns out the ifdef isn't necessary
to start with. I have a patch waiting to remove it which I wanted to send
after the commit window closes. I'll just take yours instead and modify it
to remove the #ifdef.

Thanks,
Guenter

> ---
>   drivers/hwmon/tmp108.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c
> index 1f36af2cd2d9..3dcbbb05ab2b 100644
> --- a/drivers/hwmon/tmp108.c
> +++ b/drivers/hwmon/tmp108.c
> @@ -452,7 +452,7 @@ static int p3t1085_i3c_probe(struct i3c_device *i3cdev)
>   	struct device *dev = i3cdev_to_dev(i3cdev);
>   	struct regmap *regmap;
>   
> -#ifdef CONFIG_REGMAP_I3C
> +#if IS_ENABLED(CONFIG_REGMAP_I3C)
>   	regmap = devm_regmap_init_i3c(i3cdev, &tmp108_regmap_config);
>   #else
>   	regmap = ERR_PTR(-ENODEV);