On 11/19/24 06:07, JuenKit Yip wrote:
add "compatible" property for supporting devicetree
Signed-off-by: JuenKit Yip <hunterteaegg@xxxxxxx>
---
drivers/hwmon/sht3x.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/sht3x.c b/drivers/hwmon/sht3x.c
index 650b0bcc2359..2ac1537b3e3e 100644
--- a/drivers/hwmon/sht3x.c
+++ b/drivers/hwmon/sht3x.c
@@ -954,6 +954,19 @@ static int sht3x_probe(struct i2c_client *client)
return PTR_ERR_OR_ZERO(hwmon_dev);
}
+/* devicetree ID table */
+static const struct of_device_id sht3x_of_match[] = {
+ { .compatible = "sensirion,sht30", .data = (void *)sht3x },
+ { .compatible = "sensirion,sht31", .data = (void *)sht3x },
+ { .compatible = "sensirion,sht35", .data = (void *)sht3x },
+ { .compatible = "sensirion,sts30", .data = (void *)sts3x },
+ { .compatible = "sensirion,sts31", .data = (void *)sts3x },
+ { .compatible = "sensirion,sts35", .data = (void *)sts3x },
This either needs to be "sensirion,sht3x" and "sensirion,sts3x",
and the matching entries need to be documented in the bindings document,
or each individual entry needs to be listed in the bindings document.
Also, this patch should be patch 2/2, and it needs to pass checkpatch
without warning.
+ {},
Unnecessary ",".
Guenter
