Re: [PATCH v2 1/2] hwmon: Add Congatec Board Controller monitoring driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/15/24 06:00, Thomas Richard wrote:
On 11/11/24 20:31, Guenter Roeck wrote:

I don't understand why this would be needed anyway. The current channel
index is well known, so adding or subtracting a constant should do it.

My first idea to use this macro was to avoid issue if a new voltage
sensor is added in the future.

But it's useless. If in a new generation of Board Controller a voltage
sensor is added, it will be added at the end of the list.


Exactly. And if it isn't added to the end of the list, the array with
the sensor names and types would have to change, meaning a new array
would be needed anyway. If that happens, it would be easier to just
add another constant for that second controller variation.

Thanks,
Guenter





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux