On October 31, 2024 12:50:10 PM GMT+01:00, "Zhuo, Qiuxu" <qiuxu.zhuo@xxxxxxxxx> wrote: >> From: Borislav Petkov <bp@xxxxxxxxx> >> [...] >> >> On Thu, Oct 31, 2024 at 08:09:14AM +0000, Zhuo, Qiuxu wrote: >> > This function could fail and return an error. >> > Is an early return with an error code needed if this function fails? >> >> No, grep for amd_northbridges.num checks in the code. > >If the return value of amd_cache_northbridges() isn't used in any place, >make it return void? > >-Qiuxu Feel free to propose patches *after* the dust around that area settles. -- Sent from a small device: formatting sucks and brevity is inevitable.
