On 10/30/24 08:18, Akinobu Mita wrote:
2024年10月31日(木) 0:02 Guenter Roeck <linux@xxxxxxxxxxxx>:
On 10/30/24 07:55, Akinobu Mita wrote:
2024年10月29日(火) 11:35 Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>:
This adds an optional property "retain-state-shutdown" as requested by
Billy Tsai.
Billy said:
"Our platform is BMC that will use a PWM-FAN driver to control the fan
on the managed host. In our case, we do not want to stop the fan when
the BMC is reboot, which may cause the temperature of the managed host
not to be lowered."
I confirmed that it works properly.
Reviewed-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>
Tested-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>
Thank you very much for testing.
However, I plan to change this option to device attribute
(/sys/class/hwmon/hwmonX/retain-state-shutdown) instead of the device tree.
No, I won't acccept that.
Oops, I mean /sys/device/platform/pwm-fan.X/retain-state-shutdown
not /sys/class/hwmon/hwmonX/retain-state-shutdown.
That does not make a difference. It still very much looks like a system property
to me, and making it a device property to be set by userspace just looks like
a workaround to address refusal by dt maintainers to accept the system property.
You'll have to make the case for why this is _not_ a system property for me
to accept it.
Guenter
