Re: [PATCH v4 5/9] misc: amd-sbi: Add support for mailbox error codes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 12, 2024 at 07:08:06AM +0000, Akshay Gupta wrote:
> --- a/include/uapi/misc/amd-apml.h
> +++ b/include/uapi/misc/amd-apml.h
> @@ -38,6 +38,10 @@ struct apml_message {
>  		__u32 mb_in[2];
>  		__u8 reg_in[8];
>  	} data_in;
> +	/*
> +	 * Error code is returned in case of soft mailbox
> +	 */
> +	__u32 fw_ret_code;
>  } __attribute__((packed));

You can not just randomly change the size of a user/kernel structure
like this, what just broke because of this?

confused,

greg k-h




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux