On Thu, Sep 26, 2024 at 11:38:11AM +0200, Javier Carrasco wrote:
> The device_for_each_child_node() loop requires calls to
> fwnode_handle_put() upon early returns to decrement the refcount of
> the child node and avoid leaking memory.
>
> There are multiple early returns within that loop in
> adt7475_fan_pwm_config(), but fwnode_handle_put() is never called.
> Instead of adding the missing calls, the scoped version of the loop can
> be used to simplify the code and avoid mistakes in the future if new
> early returns are added.
>
> This issue was recently introduced and it does not affect old kernels
> that do not support the scoped variant.
>
> Fixes: 777c97ff08d0 ("hwmon: (adt7475) Add support for configuring initial PWM state")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>
Applied.
Thanks,
Guenter
