Hi Wenliang, kernel test robot noticed the following build errors: [auto build test ERROR on linux/master] url: https://github.com/intel-lab-lkp/linux/commits/Wenliang/hwmon-add-new-hwmon-driver-sq52205/20240912-002906 base: linux/master patch link: https://lore.kernel.org/r/20240822074426.7241-1-wenliang202407%40163.com patch subject: [PATCH linux dev 6.11] hwmon:add new hwmon driver sq52205 config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240914/202409140727.4pErU6oc-lkp@xxxxxxxxx/config) compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project bf684034844c660b778f0eba103582f582b710c9) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240914/202409140727.4pErU6oc-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202409140727.4pErU6oc-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): In file included from drivers/hwmon/sq52205.c:12: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:25: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 548 | val = __raw_readb(PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu' 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x)) | ^ In file included from drivers/hwmon/sq52205.c:12: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:25: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); | ~~~~~~~~~~ ^ include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu' 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x)) | ^ In file included from drivers/hwmon/sq52205.c:12: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:13: In file included from include/linux/cgroup.h:25: In file included from include/linux/kernel_stat.h:8: In file included from include/linux/interrupt.h:11: In file included from include/linux/hardirq.h:11: In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1: In file included from include/asm-generic/hardirq.h:17: In file included from include/linux/irq.h:20: In file included from include/linux/io.h:14: In file included from arch/hexagon/include/asm/io.h:328: include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 585 | __raw_writeb(value, PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); | ~~~~~~~~~~ ^ In file included from drivers/hwmon/sq52205.c:12: In file included from include/linux/i2c.h:19: In file included from include/linux/regulator/consumer.h:35: In file included from include/linux/suspend.h:5: In file included from include/linux/swap.h:9: In file included from include/linux/memcontrol.h:21: In file included from include/linux/mm.h:2232: include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion] 517 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_" | ~~~~~~~~~~~ ^ ~~~ >> drivers/hwmon/sq52205.c:493:37: error: cannot assign to variable 'sq522xx_regmap_config' with const-qualified type 'const struct regmap_config' 493 | sq522xx_regmap_config.max_register = data->config->registers; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ drivers/hwmon/sq52205.c:67:35: note: variable 'sq522xx_regmap_config' declared const here 67 | static const struct regmap_config sq522xx_regmap_config = { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~ 68 | .reg_bits = 8, | ~~~~~~~~~~~~~~ 69 | .val_bits = 16, | ~~~~~~~~~~~~~~~ 70 | }; | ~ 7 warnings and 1 error generated. vim +493 drivers/hwmon/sq52205.c 460 461 static int sq522xx_probe(struct i2c_client *client) 462 { 463 struct device *dev = &client->dev; 464 struct sq522xx_data *data; 465 struct device *hwmon_dev; 466 u32 val; 467 int ret, group = 0; 468 enum sq522xx_ids chip; 469 470 if (client->dev.of_node) 471 chip = (uintptr_t)of_device_get_match_data(&client->dev); 472 else 473 chip = i2c_match_id(sq522xx_id, client)->driver_data; 474 475 data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); 476 if (!data) 477 return -ENOMEM; 478 479 /* set the device type */ 480 data->client = client; 481 data->config = &sq522xx_config[chip]; 482 mutex_init(&data->config_lock); 483 484 if (of_property_read_u32(dev->of_node, "shunt-resistor", &val) < 0) 485 val = SQ522XX_RSHUNT_DEFAULT; 486 487 488 if (val <= 0 || val > data->config->calibration_factor) 489 return -ENODEV; 490 491 data->rshunt = val; 492 > 493 sq522xx_regmap_config.max_register = data->config->registers; 494 495 data->regmap = devm_regmap_init_i2c(client, &sq522xx_regmap_config); 496 if (IS_ERR(data->regmap)) { 497 dev_err(dev, "failed to allocate register map\n"); 498 return PTR_ERR(data->regmap); 499 } 500 501 502 ret = sq522xx_init(data); 503 if (ret < 0) { 504 dev_err(dev, "error configuring the device: %d\n", ret); 505 return -ENODEV; 506 } 507 if (chip == sq52205) { 508 ret = sq52205_init(data); 509 if (ret < 0) { 510 dev_err(dev, "error configuring the device cal: %d\n", ret); 511 return -ENODEV; 512 } 513 } 514 515 data->groups[group++] = &sq522xx_group; 516 if (chip == sq52205) 517 data->groups[group++] = &sq52205_group; 518 519 hwmon_dev = devm_hwmon_device_register_with_groups(dev, client->name, 520 data, data->groups); 521 if (IS_ERR(hwmon_dev)) 522 return PTR_ERR(hwmon_dev); 523 524 dev_info(dev, "power monitor %s (Rshunt = %li uOhm)\n", 525 client->name, data->rshunt); 526 527 return 0; 528 } 529 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki