Use dev_err_probe() to simplify the error path and unify a message
template.
Using this helper is totally fine even if err is known to never
be -EPROBE_DEFER.
The benefit compared to a normal dev_err() is the standardized format
of the error code, it being emitted symbolically and the fact that
the error code is returned which allows more compact error paths.
Signed-off-by: Shen Lichuan <shenlichuan@xxxxxxxx>
---
drivers/hwmon/sht15.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c
index 494f9655f44f..cc3a46a9c68e 100644
--- a/drivers/hwmon/sht15.c
+++ b/drivers/hwmon/sht15.c
@@ -942,11 +942,9 @@ static int sht15_probe(struct platform_device *pdev)
data->supply_uv = voltage;
ret = regulator_enable(data->reg);
- if (ret != 0) {
- dev_err(&pdev->dev,
- "failed to enable regulator: %d\n", ret);
- return ret;
- }
+ if (ret != 0)
+ return dev_err_probe(&pdev->dev, ret,
+ "failed to enable regulator\n");
/*
* Setup a notifier block to update this if another device
--
2.17.1
