Re: [PATCH 08/11] hwmon: (ina2xx) Fix various overflow issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 27, 2024 at 08:34:52AM -0700, Guenter Roeck wrote:
> @@ -301,8 +307,8 @@ static int ina2xx_get_value(struct ina2xx_data *data, u8 reg,
>  		val = DIV_ROUND_CLOSEST((s16)regval, data->config->shunt_div);
>  		break;
>  	case INA2XX_BUS_VOLTAGE:
> -		val = (regval >> data->config->bus_voltage_shift)
> -		  * data->config->bus_voltage_lsb;
> +		val = (regval >> data->config->bus_voltage_shift) *
> +		  data->config->bus_voltage_lsb;

The change looks irrelevant to the patch.

Either with removing the change or not,
Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux