On Wed, Aug 21, 2024 at 09:34:09AM -0500, Mario Limonciello wrote: > On 8/21/2024 08:09, Yazen Ghannam wrote: > > On Tue, Aug 20, 2024 at 12:35:57AM -0500, Mario Limonciello wrote: > > > From: Mario Limonciello <mario.limonciello@xxxxxxx> > > > > > > This removes some boilerplate from the code and will allow adding > > > future CPUs by just device IDs. > > > > > > > I've been thinking that maybe we stop using PCI IDs entirely. > > > > The PCIe devices that we match on are internal to the SoC. And they're > > not optional. They're basically processor components that are exposed > > through PCI config space for software convenience. > > > > Thoughts? > > > > Thanks, > > Yazen > > Yeah I think that's a good idea. The one thing I want to make sure remains > though is that k10temp automatically loads from a CPU modalias. > > This is "tangential" to this patch except for the commit message reference > to the PCI IDs. > Based on the feedback I will not accept this patch but wait for a solution which is acceptable for everyone involved from AMD. Guenter