Hey > -----Ursprüngliche Nachricht----- > Von: Guenter Roeck <groeck7@xxxxxxxxx> Im Auftrag von Guenter Roeck > Gesendet: Freitag, 16. August 2024 16:21 > An: mailinglist1@xxxxxxxxxxxxxxxxxxxx; linux-hwmon@xxxxxxxxxxxxxxx > Cc: jdelvare@xxxxxxxx; Johannes Kirchmair > <johannes.kirchmair@xxxxxxxxxxx> > Betreff: Re: [PATCH] hwmon: pwmfan: do not force disable pwm controller > > On 8/15/24 23:36, mailinglist1@xxxxxxxxxxxxxxxxxxxx wrote: > > From: Johannes Kirchmair <johannes.kirchmair@xxxxxxxxxxx> > > > > The pwm1_enable attribute of the pwmfan driver influences the mode of > > operation, especially in case of a requested pwm1 duty cycle of zero. > > Especially setting pwm1_enable to two, should keep the pwm controller > > enabled even if the duty cycle is set to zero [1]. > > > > This is not the case at the moment, as the pwm controller is disabled > > always if pwm1 is set to zero. > > > > This commit tries to fix this behavior. > > > > [1] https://docs.kernel.org/hwmon/pwm-fan.html > > > > Signed-off-by: Johannes Kirchmair <johannes.kirchmair@xxxxxxxxxxx> > > --- > > drivers/hwmon/pwm-fan.c | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index > > a1712649b07e..10c4e9bcf10c 100644 > > --- a/drivers/hwmon/pwm-fan.c > > +++ b/drivers/hwmon/pwm-fan.c > > @@ -167,7 +167,7 @@ static int pwm_fan_power_on(struct pwm_fan_ctx > *ctx) > > return ret; > > } > > > > -static int pwm_fan_power_off(struct pwm_fan_ctx *ctx) > > +static int pwm_fan_power_off(struct pwm_fan_ctx *ctx, int > > +force_disable) > > Please use bool. Just send v2. Regards, Johannes > > Guenter
