On Fri, Aug 16, 2024 at 05:03:16PM -0700, Guenter Roeck wrote: > On 8/16/24 14:55, Rob Herring wrote: > > On Wed, Aug 14, 2024 at 02:17:26PM -0400, Frank Li wrote: > > > Convert binding doc ltc2978.txt to yaml format. > > > Additional change: > > > - add i2c node. > > > - basic it is regulator according to example, move it under regulator. > > > > > > Fix below warning: > > > arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/i2c@2000000/i2c-mux@77/i2c@2/regulator@5c: > > > failed to match any schema with compatible: ['lltc,ltc3882'] > > > > > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > > > --- > > > .../devicetree/bindings/hwmon/ltc2978.txt | 62 ------------ > > > .../bindings/regulator/lltc,ltc2972.yaml | 94 +++++++++++++++++++ > > > 2 files changed, 94 insertions(+), 62 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/hwmon/ltc2978.txt > > > create mode 100644 Documentation/devicetree/bindings/regulator/lltc,ltc2972.yaml > > > > I'm on the fence whether to move this... > > > > I don't really understand the rationale behind the move nor the rationale behind > the rename, but then I don't really care or mind as long as no one claims that > the _driver_ should be moved because the devicetree bindings moved. Conor suggest use one of compatible string as file name. I just help convert it. I am not familar with this chip at all. According to original docuemnt, most talk about regular instead of hwmon. If you want to keep it under hwmon, I am fine. Frank > > Note that "basic it is a regulator" is a bit stretching. The driver's regulator > functionality must be enabled with a separate configuration option; the driver > works perfectly fine as hardware monitoring driver if SENSORS_LTC2978_REGULATOR=n. > > Guenter >
