On 8/10/24 11:47 PM, Maximilian Luz wrote:
The SURFACE_AGGREGATOR_BUS option specifies whether SAM bus support is build into the SAM controller driver or not. The surface_fan module requires this, due to which it has a dependency on the option. However, from an end-user perspective, it makes more sense to automatically enable the option when choosing to include the fan driver, rather than requiring the user to know that they have to enable bus support first before they get shown the option for the fan driver. Therefore change the 'depends on' to 'select'. Signed-off-by: Maximilian Luz <luzmaximilian@xxxxxxxxx> --- drivers/hwmon/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index b60fe2e58ad6..e4d9a035a57a 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -2069,7 +2069,7 @@ config SENSORS_SFCTEMP config SENSORS_SURFACE_FAN tristate "Surface Fan Driver" depends on SURFACE_AGGREGATOR - depends on SURFACE_AGGREGATOR_BUS + select SURFACE_AGGREGATOR_BUS help Driver that provides monitoring of the fan on Surface Pro devices that have a fan, like the Surface Pro 9.
I should have properly build-tested this, sorry. It seems that it creates a recursion in Kconfig. So please disregard this, and let's stick to "depends on" until I have figured this out. Best regards, Max
