On Sat, Jul 27, 2024 at 01:20:07PM -0700, Guenter Roeck wrote: > In the MAX6581 datasheet Revision 0 to 3, the local channel overtemperature > status is reported in bit 6 of register 0x45, and the overtemperature > status for remote channel 7 is reported in bit 7. In Revision 4 and later, > the local channel overtemperature status is reported in bit 7, and the > remote channel 7 overtemperature status is reported in bit 6. A real > chip was found to match the functionality documented in Revision 4 and > later. > > The code was fixed with commit 1ea3fd1eb986 ("hwmon: (max6697) Fix swapped > temp{1,8} critical alarms"). At that time it looked like this was an > original bug. It only turned out later that the problem was the result of > incorrect information in the chip datasheet. > > Document the discrepancy to avoid confusion caused by old versions of the > datasheet. > > Cc: Tzung-Bi Shih <tzungbi@xxxxxxxxxx> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>