Re: [PATCH v2 1/8] hwmon/misc: amd-sbi: Move core sbrmi from hwmon to misc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 7/17/2024 9:56 PM, Guenter Roeck wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On 7/17/24 01:10, Akshay Gupta wrote:
This is done to support other functionality provided by the SBRMI, which
does not fit in the hwmon subsystem.

- Move the SBRMI core functionality and I2C device probing part to misc.
- Move hwmon device sensor to misc as only power is reported through
   hwmon sensor.


I fail to see the logic here. Why would the supported sensor types
be a reason or an argument for moving the hwmon code out of hwmon ?

Guenter

After we move the probe of i2c device to misc, we were using platform_device_register_data()

API to probe the hwmon sensor. Greg did not like this idea of probing, previously I have explored mfd cells

approach but was not accepted by MFD maintainer, so we thought

of calling the devm_hwmon_device_register_with_info() in misc itself.

I will update the commit message to reflect the same.

Thanks,

Akshay





[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux