Re: [PATCH RFT v3 4/4] hwmon: (spd5118) Add support for reading SPD data

[Guenter Roeck <linux@xxxxxxxxxxxx>]

On 5/31/24 16:05, Guenter Roeck wrote:
> Add support for reading SPD NVRAM data from SPD5118 (Jedec JESD300)
> compliant memory modules. NVRAM write operation is not supported.
>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> v3: New patch
>
> RFT: I'd like to get some more test coverage before moving forward
>       with this patch. decode-dimms doesn't recognize the 'spd5118'
>       driver.

Looking for feedback:

[ ... ]

> +
> +	nvmem = devm_nvmem_register(dev, &nvmem_config);

This returns ERR_PTR(-EOPNOTSUPP) if CONFIG_NVRAM=n. We have two options:

- Ignore -EOPNOTSUPP and continue registering the hwmon device

or

- Add
	select NVRAM
	select NVRAM_SYSFS
  to the driver's Kconfig entry.

Any preferences ?
	
Thanks,
Guenter