On 2024-05-28 06:39:03+0000, Tzung-Bi Shih wrote: > On Mon, May 27, 2024 at 10:58:31PM +0200, Thomas Weißschuh wrote: > > +/** > > + * cros_ec_cmd_readmem - Read from EC memory. > > + * > > + * @ec_dev: EC device > > + * @offset: Is within EC_LPC_ADDR_MEMMAP region. > > + * @size: Number of bytes to read. zero means "read a string" (including > > + * the trailing '\0'). > > The behavior is cros_ec_lpc_readmem() only but not for cros_ec_cmd(). Indeed. I thought I checked for this specifically, but got it wrong. I'll drop the docs and add a if (!size) return -EINVAL; to make sure nobody starts relying on that behaviour when writing a driver against an LPC EC.
