On 5/12/24 22:52, Noah Wang wrote:
This driver is designed for MPS VR controller mp2891. The input voltage, output voltage, input current, output current, input power, output power and temperature of per rail can be obtained from hwmon sysfs that the driver provided. Signed-off-by: Noah Wang <noahwang.wang@xxxxxxxxxxx>
The chip name looked vaguely familiar, and indeed I found: https://patchwork.kernel.org/project/linux-hwmon/patch/TYZPR03MB7130A7F41D61BFB611DDF0C7FA479@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ So this is really v2 of your patch without saying so, it pretty much ignores all feedback I sent as response to v1, and it does drop support for limit and status attributes for no reason. Please don't do that. Guenter