On Wed, May 08, 2024 at 03:18:37PM +0200, Lars Petter Mostad wrote: > EMC1428 and EMC1438 are similar to EMC14xx, but have eight temperature > channels, as well as signed data and limit registers. Chips currently > supported by this driver have unsigned registers only. > > Signed-off-by: Lars Petter Mostad <lars.petter.mostad@xxxxxxxxxx> checkpatch says: WARNING: From:/Signed-off-by: email address mismatch: 'From: Lars Petter Mostad <larspm@xxxxxxxxx>' != 'Signed-off-by: Lars Petter Mostad <lars.petter.mostad@xxxxxxxxxx>' Both have to be the same. Either consistently use the gmail address, or (assuming you use gmail to send your e-mails) set up gmail to accept lars.petter.mostad@xxxxxxxxxx as From address. > --- > drivers/hwmon/emc1403.c | 121 ++++++++++++++++++++++++++++++++++++---- Please also update Documentation/hwmon/emc1403.rst. Other than that, looks good. The changes pass my module test for all chips, so I don't expect any problems. Please submit v2 with above changes. Thanks, Guenter
