On 29/04/2024 14:03, Inochi Amaoto wrote: > Due to the design, Sophgo SG2042 use an external MCU to provide > hardware information, thermal information and reset control. > > Add bindings for this monitor device. > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxxxx> > --- > .../hwmon/sophgo,sg2042-hwmon-mcu.yaml | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml b/Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml > new file mode 100644 > index 000000000000..64a8403aaab8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml > @@ -0,0 +1,40 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/sophgo,sg2042-hwmon-mcu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sophgo SG2042 onboard MCU support > + > +maintainers: > + - Inochi Amaoto <inochiama@xxxxxxxxxxx> > + > +properties: > + compatible: > + const: sophgo,sg2042-hwmon-mcu > + > + reg: > + maxItems: 1 > + > + "#thermal-sensor-cells": > + const: 1 This looks like thermal sensor, so you miss ref to thermal-sensor.yaml in top-level. Just like other sensors. > + > +required: > + - compatible > + - reg > + - "#thermal-sensor-cells" > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + syscon@17 { Are you sure this is syscon? Title says mcu, compatible says hwmon... Best regards, Krzysztof
