On Mon, 2024-04-22 at 22:19 +0000, Luck, Tony wrote: > > > Unfortunately, it ended up being simplified to just include arch/x86 > > > directly. > > > > Reading through that other thread (Iwona: thanks for the link) it seems that > > moving > > the x86 include files out of arch/x86/include/asm has been soundly rejected. > > > > I'm going to take Iwona's advice above and copy the VFM_* macros. > > Iwona, > > I just pushed what might become v4 of this series to: > > git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git > new_families_v4 > > If you have a moment, could you please check whether the peci bits build on > a non-x86 system. It still doesn't compile because X86_VENDOR_INTEL is missing in include/linux/peci-cpu.h: We need something like: diff --git a/include/linux/peci-cpu.h b/include/linux/peci-cpu.h index 218fc9372..38cb61203 100644 --- a/include/linux/peci-cpu.h +++ b/include/linux/peci-cpu.h @@ -6,6 +6,9 @@ #include <linux/types.h> +/* Copied from x86 <asm/processor.h> */ +#define X86_VENDOR_INTEL 0 + /* Copied from x86 <asm/cpu_device_id.h> */ #define VFM_MODEL_BIT 0 #define VFM_FAMILY_BIT 8 Thanks -Iwona > > Thanks > > -Tony
