RE: [PATCH v2 0/2] Add adm1281 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck
> Sent: Monday, April 22, 2024 11:45 AM
> To: Krzysztof Kozlowski <krzk@xxxxxxxxxx>; SanBuenaventura, Jose
> <Jose.SanBuenaventura@xxxxxxxxxx>; linux-hwmon@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> doc@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx
> Cc: Jean Delvare <jdelvare@xxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Jonathan Corbet <corbet@xxxxxxx>; Delphine CC
> Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> Subject: Re: [PATCH v2 0/2] Add adm1281 support
> 
> [External]
> 
> On 4/21/24 20:28, Krzysztof Kozlowski wrote:
> > On 22/04/2024 04:51, Jose Ramon San Buenaventura wrote:
> >> This patch removes the extra case added in the adm1275_read_byte_data
> >> for STATUS_CML reads. Upon checking, the reads for the STATUS_CML
> >> register is already handled in the pmbus_core.
> >>
> >> It was also clarified and agreed upon that any other actionable steps
> >> involving the STATUS_CML error flags should be added in the
> >> pmbus_core and not on the specific chip driver.
> >>
> >
> > Where is the changelog? It's v2, so what happened here?
> >
> 
> Same question.
> 
> Guenter
> 

Hello,

The only change from v1 to v2 is the removal of the additional case
for STATUS_CML in the adm1275_read_byte_data function in the adm1275.c
driver code. No changes were done in the other files, only in the driver code.

I apologize for the confusion.

For clarification, do I need to resend the patches and include a changelog
in the patch that specifies the changes done i.e., v1 -> v2: removed case?

Joram




[Index of Archives]     [LM Sensors]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux