On Thu, Apr 18, 2024 at 08:31:42AM +0000, SanBuenaventura, Jose wrote: > > The lines mentioned were added initially because the STATUS_CML read capability > seems to be only available in the adm1281 and so reading the said register with > another device shouldn't be permitted. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Why ? Sure, doing so causes the CML bit to be set, but the PMBus core uses that method throughout to determine if a command/register is supported. There are exceptions - some chips react badly if an attempt is made to read unsupported registers. That is not the case for chips in this series, at least not for the ones where I have evaluation boards. In such cases, the chip driver should do nothing and let the PMBus core do its job. > It seems though that the functionality is redundant and is already handled by > the PMBus core and maybe these lines can be removed and CML related errors > can be checked using the status0 and status0_cml debugfs entries. This has nothing to do with status0 and status0_cml debugfs entries. The PMBUs core reads STATUS_CML if the CML status bit is set in the status byte/word to determine if a command is supported or not. This is as intended. There is nothing special to be done by a chip driver. Thanks, Guenter
