On Sat, Mar 30, 2024 at 12:24:00PM +0100, Maximilian Luz wrote: > Some of the newer Microsoft Surface devices (such as the Surface Book > 3 and Pro 9) have thermal sensors connected via the Surface Aggregator > Module (the embedded controller on those devices). Add a basic driver > to read out the temperature values of those sensors. > > Link: https://github.com/linux-surface/surface-aggregator-module/issues/59 > Signed-off-by: Maximilian Luz <luzmaximilian@xxxxxxxxx> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> CHECK: Please don't use multiple blank lines #189: FILE: drivers/hwmon/surface_temp.c:17: + + CHECK: Please don't use multiple blank lines #229: FILE: drivers/hwmon/surface_temp.c:57: + + CHECK: Alignment should match open parenthesis #311: FILE: drivers/hwmon/surface_temp.c:139: + hwmon_dev = devm_hwmon_device_register_with_info(&sdev->dev, + "surface_thermal", ssam_temp, &ssam_temp_hwmon_chip_info, Please fix. Guenter
