On Wed, Feb 21, 2024 at 06:40:25PM +0800, Billy Tsai wrote:
> The driver support two functions: PWM and Tachometer. The PWM feature can
> handle up to 16 output ports, while the Tachometer can monitor to up to 16
> input ports as well. This driver implements them by exposing two kernel
> subsystems: PWM and HWMON. The PWM subsystem can be utilized alongside
> existing drivers for controlling elements such as fans (pwm-fan.c),
> beepers (pwm-beeper.c) and so on. Through the HWMON subsystem, the driver
> provides sysfs interfaces for fan.
>
> Signed-off-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx>
Applied to hwmon-next. There was an outstanding suggestion:
> > +static int aspeed_pwm_tach_remove(struct platform_device *pdev)
> > +{
> > + struct aspeed_pwm_tach_data *priv = platform_get_drvdata(pdev);
> > +
> > + reset_control_assert(priv->reset);
>
> This is already done by aspeed_pwm_tach_reset_assert(), looks like
> aspeed_pwm_tach_remove() can be removed. With that, priv->reset can
> become a local variable in aspeed_pwm_tach_probe().
I'll be happy to apply a follow-up patch making this change.
Thanks,
Guenter
